Help! Wokrs well on my computer, error on the site

Question about the task

Resolved

Hello! I get my solution rejected with the following requirements violated: - The program should display the number of positive numbers in the original set. - If there are no positive numbers, the program should display "0". I copied the code to the IDE on my computer, and it works well. I tried different inputs like (-1, -1, -1), (0, -1, 1), (0, 0, 1), (-1, 1, 1), (1, 1, 1) and the examples from the problem statement, and always got the correct output. So the question is - what's going on?

Use the keyboard to enter three integers. Display the number of positive numbers in the original set.

Here are some examples:
a) if you enter the numbers
-4 6 6
then we display
2

b) if you enter the numbers
-6 -6 -3
then we display
0

c) if you enter the numbers
0 1 2
then we display
2

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The program should display the number of positive numbers in the original set.
If there are no positive numbers, the program should display "0".
Note that 0 is not a positive or negative number.

package en.javarush.task.jdk13.task04.task0428; import java.io.BufferedReader; import java.io.InputStreamReader; /* Positive number */ public class Solution { static int count = 0; public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); if (a > 0) {Solution.count ++;} int b = Integer.parseInt(reader.readLine()); if (b > 0) {Solution.count ++;} int c = Integer.parseInt(reader.readLine()); if (c > 0) {Solution.count ++;} System.out.println(Solution.count); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

hidden #598481

Level 27

30 May 2022, 15:06

You shouldn't use static variable for count, create local variable inside the method instead. When tests run your code it has several runs inside of it. Something like this:

void testMethod() {
    // ... first input
    Solution.main(new String[0]); // runs your code
    assertResult(); // compares your output with correct one
    // ... second input
    Solution.main(new String[0]); // runs your code again with second input
    assertResult(); // compares your new output with correct one
    ...
}

And if you use static variable for counter it starts summing the results of each run. That is why your test will fail. Of course you can start your method with command count = 0 resetting your counter before each run but it is more preferrable just to move it into the method.

logvinata

Level 13

1 June 2022, 09:26

Thank you! This is quite useful and I'd never figure it out on my own